-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename InvRing
+ small changes to invariant theory
#3442
Conversation
Just mentioning here, that |
I make this a draft as it creates conflicts with #3443. Also, we should settle the |
@joschmitt Sorry, I have seen your PR only now. |
Don't worry. This is only internal changes and can wait. |
I am neutral on the Regarding |
Okay, I will change everything to |
This is good to go from my side, but waiting for #3469. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3469 is in, so now a conflict needs to be resolved. Otherwise seems fine to me, thanks
* use `monomials_of_degree` * `NullConeIdeal` -> `null_cone_ideal` * remove unnecessary exports
`InvRing` -> `FinGroupInvarRing` `RedGrpInvRing` -> `RedGroupInvarRing` `TorGrpInvRing` -> `TorGroupInvarRing`
This is good to go now (once CI approves). |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3442 +/- ##
==========================================
- Coverage 81.93% 81.93% -0.01%
==========================================
Files 563 563
Lines 75550 75541 -9
==========================================
- Hits 61901 61892 -9
Misses 13649 13649
|
Rename:
InvRing
toFinGroupInvarRing
RedGrpInvRing
toRedGroupInvarRing
TorGrpInvRing
toTorGroupInvarRing
The renamings do not interfere with the book and are no breaking changes since they are either internal or in experimental.
I made further small internal changes to the experimental invariant theory (which do not interfere with the book).
This contains the changes from #3469, I will rebase once that is merged.